TypeError / domained

Multi Tool Subdomain Enumeration
GNU General Public License v3.0
722 stars 157 forks source link

massdns error #19

Closed RnmX closed 5 years ago

RnmX commented 6 years ago

Hello guys,

I was experimenting with this tools recently I and found it's current implementation does not work well with massdns. I noticed the sublister which is used by domained (/bin/sublister/sublister.py) behaves differently from sublister.py which is presented in /bin/massdns/sublister.py. If I run "python domained.py -b domain.com -b --bruteall" I never actually get to see massdns's "status screen" and it looks like it got stuck.

I was able to make it work by changing these lines: massdnsCMD = 'python {} -s {} {} | {} -r resolvers.txt -t A -a -o -w {}-massdns.txt -'.format( os.path.join(script_path, 'bin/subbrute/subbrute.py'), word_file, domain,

to look like this:

massdnsCMD = 'python {} {} {} | {} -r resolvers.txt -t A -a -o -w {}-massdns.txt -'.format( os.path.join(script_path, 'bin/massdns/subbrute.py'), word_file, domain,

Then it works perfectly fine.

Thanks!

cak commented 6 years ago

@RnmX Thanks for reporting the issue (and the fix!) with the massdns command! If you would like to do a pull request I will get it tested and merged ASAP or if not I can update and push out.

cak commented 6 years ago

@RnmX Thank you for your patience. I am still testing this to ensure that removing the -s flag does not just appear to be working faster because it has SubBrute bypass the large word list and if so, would it be beneficial to have another function (replacing or additional) to interact with massdns without SubBrute?

RnmX commented 6 years ago

Hello there!

Sorry for not replying but I was off for holidays. How is your testing going?

cak commented 5 years ago

@RnmX Sorry for the delay, I validated and pushed your fix for MassDNS. Please let me know if any other issues. Thanks again!