Closed Stuey61296 closed 1 year ago
@Stuey61296 what about making the monaco-languageclient-examples package publicly available on npm. Then we could just take the server from there. This would also be helpful with the json languageserver. We have just keep the start scripts here and use the dependencies from node_modules. I will test this.
@Stuey61296 what about making the monaco-languageclient-examples package publicly available on npm. Then we could just take the server from there. This would also be helpful with the json languageserver. We have just keep the start scripts here and use the dependencies from node_modules. I will test this.
I think this a good idea, will definitely make it easier to maintain going forward. Do you need me to look into this or will you do it as part of the next release you do?
Do you need me to look into this or will you do it as part of the next release you do?
I will test this (release new packages) with the json example and if that works you could rebase this PR and do the same with the python server.
@Stuey61296 Done. The server integrations for python and json LSs are already available on main. Please rebase the PR.
I performed the rebase here already: https://github.com/TypeFox/monaco-components/tree/react-python
You can reset your branch to there if you like. The changes look good already and it works as expected.
I now merged the rebased version as there were no further changes required from your side. Your name is on the changes! 🎉 I only removed what I wrote above. I will release the new major versions later today.
@Stuey61296 versions 3.0.0 and 2.0.0 are now available: https://www.npmjs.com/package/monaco-editor-wrapper/v/3.0.0 https://www.npmjs.com/package/@typefox/monaco-editor-react/v/2.0.0