Improve configuration change detection - Githubissues

TypeFox / monaco-components

Monaco Editor and Language Client Wrapper, plus Monaco Editor React Component

MIT License

42 stars 13 forks source link

Improve configuration change detection #47

Closed kaisalmen closed 11 months ago

kaisalmen commented 12 months ago

Fixes #46

The configuration change detection in componentDidUpdate is not correct. It interprets model related updates as application configuration updates. This PR introduces better logic to the wrapper and thereby shortens the react-component code.

There are now three levels of update protection:

It is checked if the editor app config is changed
It is checked if only the code or if the model changed