search

TypeFox / monaco-languageclient

Repo hosts npm packages for monaco-languageclient, vscode-ws-jsonrpc, monaco-editor-wrapper, @typefox/monaco-editor-react and monaco-languageclient-examples
https://www.npmjs.com/package/monaco-languageclient
MIT License
1.05k stars 178 forks source link

Move localeLoader to monaco-languageclient #672

Closed kaisalmen closed 3 months ago

kaisalmen commented 3 months ago

It makes more sense there, because this is not a specific functionality of the wrapper and could then be used without it. WDYT?

CGNonofr commented 3 months ago

I'm not sure about the exact architectures of the projects, it doesn't seem really related to the languageclient package to me

kaisalmen commented 3 months ago

I'm not sure about the exact architectures of the projects, it doesn't seem really related to the languageclient package to me

It is more a utility function for monaco-vscode-api, but you don't need the wrapper for it. But, if you think it should not go to the client, I will leave it where it currently is and close this PR without merging.

kaisalmen commented 3 months ago

@CGNonofr I changed my mind and let it stay where it is.