[6.0.0-next.6] ViewDescriptorService missing

cdietrich commented 3 weeks ago

hi, where/how do i configure

ViewDescriptorService.getViewContainersByLocation is not supported. You are using a feature without registering the corresponding service override.
    at ViewDescriptorService.unsupported5 (missing-services.js:220:15)
    at getDefaultViewContainer (views.js:309:35)
    at initLayoutState (views.js:317:103)
    at UniqueContainer.value (views.js:333:5)
    at Emitter._deliver (event.js:677:22)
    at Emitter._deliverQueue (event.js:686:18)
    at Emitter.fire (event.js:703:18)
    at lifecycle.js:55:32
    at _InstantiationService.invokeFunction (instantiationService.js:77:20)
    at startup (lifecycle.js:50:31)

cdietrich commented 3 weeks ago

the naive

import getLayoutServiceOverride from "@codingame/monaco-vscode-layout-service-override" userServices: { ...., ...getLayoutServiceOverride(), }

does not seem to work

CGNonofr commented 3 weeks ago

Do you have more context? what are you trying to do?

Also the layout service override has nothing to do with the ViewDescriptorService

cdietrich commented 3 weeks ago

i just try to update our editor classic config to the newest preview config

import getConfigurationServiceOverride from "@codingame/monaco-vscode-configuration-service-override"
import getEditorServiceOverride from "@codingame/monaco-vscode-editor-service-override"
import getKeybindingsServiceOverride from "@codingame/monaco-vscode-keybindings-service-override"
import type { languages } from "monaco-editor"
import type { WrapperConfig } from "monaco-editor-wrapper"
import { MonacoEditorLanguageClientWrapper } from "monaco-editor-wrapper"
import { useOpenEditorStub } from "monaco-editor-wrapper/vscode/services"
import { useWorkerFactory } from "monaco-editor-wrapper/workerFactory"
import type { Logger } from "monaco-languageclient/tools"

const setupConfigClassic = (
  url: string,
  languageId: string,
  text: string,
  fileExt: string,
  htmlElement: HTMLElement,
  monarch?: languages.IMonarchLanguage
): WrapperConfig => {
  const loadLangiumWorker = () => {
    console.log(`Langium worker URL: ${url}`)
    return new Worker(new URL(url, import.meta.url), {
      type: "module",
      name: "Our Language Server Worker",
    })
  }
  const langiumWorker = loadLangiumWorker()
  return {
    vscodeApiConfig: {
      userServices: {
        ...getConfigurationServiceOverride(),
        ...getEditorServiceOverride(useOpenEditorStub),
        ...getKeybindingsServiceOverride(),
      },
    },
    editorAppConfig: {
      $type: "classic",
      codeResources: {
        main: {
          text,
          fileExt,
          enforceLanguageId: languageId,
        },
      },
      htmlContainer: htmlElement,
      useDiffEditor: false,
      languageDef: {
        monarchLanguage: monarch,
        languageExtensionConfig: {
          id: languageId,
          extensions: [`.${fileExt}`],
        },
      },
      editorOptions: {
        "semanticHighlighting.enabled": true,
        theme: "vs-dark",
      },
      monacoWorkerFactory: (logger?: Logger) => {
        useWorkerFactory({
          logger,
          workerOverrides: {
            ignoreMapping: true,
            workerLoaders: {
              TextEditorWorker: () => {
                return new Worker(new URL("../libs/monaco-editor-workers/editorWorker-es.js", import.meta.url), {
                  type: "module",
                })
              },
            },
          },
        })
      },
    },
    languageClientConfigs: {
      our: {
        languageId,
        connection: {
          options: {
            $type: "WorkerDirect",
            worker: langiumWorker,
          },
        },
      },
    },
  }
}

export const executeClassic = async (
  htmlElement: HTMLElement,
  url: string,
  languageId: string,
  text: string,
  fileExt: string,
  monarch?: languages.IMonarchLanguage
): Promise<void> => {
  const userConfig = setupConfigClassic(url, languageId, text, fileExt, htmlElement, monarch)
  const wrapper = new MonacoEditorLanguageClientWrapper()
  await wrapper.initAndStart(userConfig)
}

cdietrich commented 3 weeks ago

and this gives the error in the first comment.

cdietrich commented 3 weeks ago

the build in example in this repo does not seem to use

getEditorServiceOverride(useOpenEditorStub)

kaisalmen commented 3 weeks ago

viewsConfig is not mandatory in the config. If it is not specified the editor service is used. You don't need to specify getEditorServiceOverride(useOpenEditorStub) yourself, but it should also not break things. habe you updated all monaco-vscode-api packages to 10.1.4?

cdietrich commented 3 weeks ago

Yes we use 10.1.4 everywhere. Removing it (the override) solves the problem but we carried it over from a year old example or so

kaisalmen commented 2 weeks ago

@cdietrich we should mention breaking changes more explicitly in the CHANGELOG or have an upgrade guide (but that is additional maintenance effort). I go with adjusting the CHANGELOG first. 🙂

CGNonofr commented 2 weeks ago

I'm not sure I follow here, what breaking change are we talking about?

kaisalmen commented 2 weeks ago

@CGNonofr generally speaking. From v8 -> v9 or V5 -> v6 (in case of the wrapper)