search

TypeFox / open-collaboration-tools

Open Collaboration Tools: live-sharing solution for Eclipse Theia, VS Code and other editors and IDEs
https://www.open-collab.tools/
MIT License
81 stars 5 forks source link

Always keep session member view up-to-date #40

Open msujew opened 1 month ago

msujew commented 1 month ago

Closes https://github.com/TypeFox/open-collaboration-tools/issues/36

This fixes the issue of missing users in the session view. The main issue was that we didn't call onDidUsersChange in our collaboration instance on a few of the peer related requests. Especially important is the peer/init notification: Upon joining a room their view was empty - only after another user joins would their view get populated. Now the view is populated instantly.

jonah-iden commented 1 month ago

Weirdly enough it worked fine yesterday but today i had the same problem as Miro. Seems like in this case when you are the host you are not in the list of peers in the collaboration instance. But when you are joining a session you are. Also on host side i only see the joined user and not myself as if in that case the host is not adding itself to the list. No Idea why both sides worked fine yesterday. Maybe some build/install problem