search

TypeFox / vscode-messenger

RPC messaging library for the VS Code extension platform
MIT License
33 stars 3 forks source link

Notification is not delivered when using an empty receiver object #11

Closed dhuebner closed 1 year ago

dhuebner commented 1 year ago

Following notification will not be redirected:

sendNotification( { method: 'note' }, {}, { param: 'test'} )

New API uses HOST_EXTENSION, old one used an empty object {} to mark the receiver as the host extension. We should support the old API and try to mark it as deprecated with a hint to use HOST_EXTENSION instead.

dhuebner commented 1 year ago

It turned out that the client project used anytype for messenger. Using the old API {} is not possible in the current version and should be fixed on client side by using HOST_EXTENSION constant.