search

TypeFox / vscode-messenger

RPC messaging library for the VS Code extension platform
MIT License
33 stars 3 forks source link

Runtime errors in async requests are not reported as response error #12

Closed dhuebner closed 1 year ago

dhuebner commented 1 year ago

In some cases, when e.g. an error is thrown in async handler, diagnostic API produces an empty response event instead of marking it as an error

dhuebner commented 1 year ago

It turned out that the handler implementation itself caught an Error and returned an empty result. Added a test to make sure it works as expected