GH-154: Replaced the lists with sets for the xpath computations.

TypeFox / yang-lsp

A Language Server for YANG

http://www.yang-central.org

Apache License 2.0

51 stars 13 forks source link

GH-154: Replaced the lists with sets for the xpath computations. #155

Closed kittaakos closed 5 years ago

kittaakos commented 5 years ago

As a quick solution for a performance issue when resolving complex long paths.

Closes: #154.

kittaakos commented 5 years ago

@svenefftinge, can you please look into the changes? Thanks!

svenefftinge commented 5 years ago

@huyuwen were you able to test the change against your models?

kittaakos commented 5 years ago

I have replaced the HashSet with a LinkedHashSet.

huyuwen commented 5 years ago

Not yet, I will do it ASAP. Sorry for delay.

Akos Kitta notifications@github.com 于2018年11月20日周二上午10:46写道：

I have replaced the HashSet with a LinkedHashSet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theia-ide/yang-lsp/pull/155#issuecomment-440209608, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxaKWJOMHdfsiq406neSW861VZLW-omks5uw8-BgaJpZM4Ynkep .

kittaakos commented 5 years ago

I am merging this now.

huyuwen commented 5 years ago

I just test locally with our own data. The solution works fine. I will test yang-lsp again when I used the latest generated package later.

Really thanks.