search

TypeFox / yang-lsp

A Language Server for YANG
http://www.yang-central.org
Apache License 2.0
51 stars 13 forks source link

null uriToProblem in validation issue #196 #198

Closed dhuebner closed 3 years ago

dhuebner commented 3 years ago

Adds uri to problem if missing. Normally happens when syntactic error occurs outside a semantic object.

spoenemann commented 3 years ago

I see similar test errors as in https://github.com/theia-ide/yang-lsp/pull/199#issuecomment-818524894:

io.typefox.yang.tests.integration.GoodTests > checkDiagnostics[augment-sub1.yang] FAILED
    org.junit.ComparisonFailure at GoodTests.java:201

io.typefox.yang.tests.integration.GoodTests > checkDiagnostics[augment-super.yang] FAILED
    org.junit.ComparisonFailure at GoodTests.java:201

@dhuebner shall we mark that test as ignored until it is fixed?

github-actions[bot] commented 3 years ago

Unit Test Results

     58 files  ±0       58 suites  ±0   58s :stopwatch: +4s 1 612 tests +1  1 611 :heavy_check_mark: +1  1 :zzz: ±0  0 :x: ±0 

Results for commit d5695617. ± Comparison against base commit 4f431948.

github-actions[bot] commented 3 years ago

Unit Test Results

     58 files  ±0       58 suites  ±0   55s :stopwatch: ±0s 1 612 tests ±0  1 611 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit c59f4bd0. ± Comparison against base commit c59f4bd0.