Closed dhuebner closed 3 years ago
The change looks good, but I get two test errors when running ./gradlew build
in Gitpod:
io.typefox.yang.tests.integration.GoodTests > checkDiagnostics[ietf-snmp-tls.yang] FAILED
org.junit.ComparisonFailure at GoodTests.java:201
io.typefox.yang.tests.integration.GoodTests > checkDiagnostics[augment-super.yang] FAILED
org.junit.ComparisonFailure at GoodTests.java:201
@dhuebner are these unrelated?
It would be great to have pull request validation. Could you add a GitHub workflow for that? See for example this CI workflow (without the NodeJS / Yarn / Docker stuff).
io.typefox.yang.tests.integration.GoodTests > checkDiagnostics[ietf-snmp-tls.yang] FAILED org.junit.ComparisonFailure at GoodTests.java:201 io.typefox.yang.tests.integration.GoodTests > checkDiagnostics[augment-super.yang] FAILED org.junit.ComparisonFailure at GoodTests.java:201
@dhuebner are these unrelated?
I successfully ran all the tests locally before pushing. I hope it doesn't depend on gradle vs. local junit testing.
It would be great to have pull request validation. Could you add a GitHub workflow for that? See for example this CI workflow (without the NodeJS / Yarn / Docker stuff).
Will do!
@spoenemann
On my Mac all tests are passing (junit and gradle). Github Action build reports 4 failing tests, you reported 2 failing tests, me (using gitpod.io) can report 1 failing test.
In my case linker can't link to "/interfaces/ifEntry"
in src/test/resources/good/augment-super.yang
I would like to investigate this tomorrow (can't imagine it is related to my changes)
57 files 57 suites 58s :stopwatch: 1 607 tests 1 602 :heavy_check_mark: 1 :zzz: 4 :x:
For more details on these failures, see this check.
Results for commit 81eb0cb5.
58 files 58 suites 59s :stopwatch: 1 610 tests 1 609 :heavy_check_mark: 1 :zzz: 0 :x:
Results for commit 44d7aae2.
@spoenemann I think it can be merged now
58 files 58 suites 56s :stopwatch: 1 610 tests 1 609 :heavy_check_mark: 1 :zzz: 0 :x:
Results for commit 41fa747a.
58 files ±0 58 suites ±0 54s :stopwatch: ±0s 1 611 tests ±0 1 610 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0
Results for commit 4f431948. ± Comparison against base commit 4f431948.
Scoping: consider sibling first when multiple candidates are available