search

TypeFox / yang-lsp

A Language Server for YANG
http://www.yang-central.org
Apache License 2.0
51 stars 13 forks source link

Maven publish with GitHub Actions and Gradle 7 compatibility #206

Closed kaisalmen closed 3 years ago

kaisalmen commented 3 years ago

The gradle build instruction use a an old maven plugin which is incompatible with Gradle 7. This PR replaces the it with maven-publish plugin and introduces the sign pluging.

Further gradle 7 build deprecation issues have been fixed (compile step and duplication strategy).

GitHub Actions deploy build artifacts on every successful master builds (enhancement to main.yml) GitHub Actions deploy release artifacts on release via GitHub and when the version does not contain "SNAPSHOT".

kaisalmen commented 3 years ago

Ok, a pull-request should trigger a build, but no deployment. This needs to be fixed.

github-actions[bot] commented 3 years ago

Unit Test Results

     58 files  ±0       58 suites  ±0   55s :stopwatch: -1s 1 621 tests ±0  1 620 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit 13dc6873. ± Comparison against base commit 6820dead.

spoenemann commented 3 years ago

@kaisalmen you can add a condition like this: https://github.com/eclipse/openvsx/blob/3c17e06825484655a5d5904df73191c07f81530e/.github/workflows/main.yml#L45

kaisalmen commented 3 years ago

@spoenemann thanks and I need to split the steps as well, build always, condition for publish

kaisalmen commented 3 years ago

Is there a specific reason you have the repository name in the if condition? Isn't the branch name sufficient or is there another reason I am not aware of?

github-actions[bot] commented 3 years ago

Unit Test Results

     58 files  ±0       58 suites  ±0   49s :stopwatch: -7s 1 621 tests ±0  1 620 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit 4e35b84f. ± Comparison against base commit 6820dead.

spoenemann commented 3 years ago

Is there a specific reason you have the repository name in the if condition?

To skip the publishing step when someone forks the repository.

github-actions[bot] commented 3 years ago

Unit Test Results

     58 files  ±0       58 suites  ±0   1m 2s :stopwatch: +6s 1 621 tests ±0  1 620 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit 2cff3e72. ± Comparison against base commit 6820dead.

github-actions[bot] commented 3 years ago

Unit Test Results

     58 files  ±0       58 suites  ±0   53s :stopwatch: ±0s 1 621 tests ±0  1 620 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit a0bddff6. ± Comparison against base commit a0bddff6.