search

TypeRocket / core

TypeRocket core source files where all the magic lives.
https://typerocket.com
36 stars 21 forks source link

Add ability to add attributes to repeater #41

Closed zackphilipps closed 5 years ago

zackphilipps commented 5 years ago

related to https://github.com/TypeRocket/core/pull/23 but probably useful for other things

kevindees commented 5 years ago

Hey @zackphilipps

Why the hidden field?

Thanks, Kevin

zackphilipps commented 5 years ago

What else would you add it to? On every other field, the attributes are added to the actual input AFAIK. I mean, it would make sense to standardize this across all fields by adding a wrapper (or using the existing one) that always has the same class. Since, for instance, you cannot add attributes to TinyMCE (on the other hand, that is getting replaced by Gutenberg)

zackphilipps commented 5 years ago

For more context, my conditional logic jquery targets each field based on its input name and data- attributes added to that input.