TypeStrong / atom-typescript

The only TypeScript package you will ever need
https://atom.io/packages/atom-typescript
MIT License
1.13k stars 205 forks source link

tsserver crashed at OS level #1255

Closed ZuBB closed 4 years ago

ZuBB commented 7 years ago

just got this today

screen shot 2017-05-10 at 19 21 12

screen shot 2017-05-10 at 19 22 20

https://gist.github.com/ZuBB/f3f6074de207fdd4b1353c4bba3e38b5

I am not sure if we can get something from this but I believe we should have everything logged

guncha commented 7 years ago

Thanks for reporting! Yeah, not sure what can be done about this now, but let's see if other people are having similar issues.

ZuBB commented 7 years ago

got one more crash on same? subject https://gist.github.com/ZuBB/41111cf4b96cb164dcf5bd3608f8339b

guncha commented 7 years ago

Looks like an OOM (out of memory) error. You might have a better luck with a newer (or older) compiler version.

ZuBB commented 7 years ago

one crash but with different? msg

Typescript quit unexpectedly
Last output from tsserver:
node::Abort() [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 2: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&) [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 3: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 6: v8::internal::OrderedHashTable<v8::internal::OrderedHashMap, v8::internal::JSMapIterator, 2>::EnsureGrowable(v8::internal::Handle<v8::internal::OrderedHashMap>) [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 7: v8::internal::Runtime_MapGrow(int, v8::internal::Object**, v8::internal::Isolate*) [/Applications/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib]
 8: 0x2a04b2a084e7
 9: 0x2a04b3e2000a
guncha commented 7 years ago

It's still an OOM error. Does it happen after you've been working for a while? Unless we're doing something bad like not closing files (which we are), this is a tsserver issue. If you're up for a good time, you can modify atom-typescript to pass --inspect to the tsserver process, connect to it with a debugger and poke around what's causing the memory bloat.

ZuBB commented 7 years ago

ok, sorry for a kind of dup. // busy to go with debug

ZuBB commented 7 years ago

hi there.

I think we have some good news for this. imo this is being caused by this https://github.com/Microsoft/TypeScript/issues/14628.

in ts repo there are couple of bug reports on same subject, but this seems to have most details and caused lots of investigation. although solution is still not found

lierdakil commented 6 years ago

For posterity: Basically, the resolution seems to boil down to https://sandersn.github.io/manual/Workarounds-for-Out-of-Memory-Crashes.html, and if that doesn't help, file an issue on https://github.com/Microsoft/TypeScript

github-actions[bot] commented 4 years ago

This issue has been marked as stale because it did not have any activity for the last 90 days or more. Remove the stale label or comment or this will be closed in 14 days