search

TypeStrong / atom-typescript

The only TypeScript package you will ever need
https://atom.io/packages/atom-typescript
MIT License
1.13k stars 205 forks source link

allowJs and checkJs config #1467

Closed jrobinson01 closed 5 years ago

jrobinson01 commented 5 years ago

In reading other issues, it doesn't look like checking .js files is supported out of the box, nor by adding the allowJs and checkJs compiler options to tsconfig.json. ~It DOES seem however, that adding a comment to the top of your .js files // @ts-check gets it working, except that it complains about that comment.~ this seems to be coming from the "ide-typescript" plugin and not "atom-typescript".

I see that support for allowJs and checkJs is up for grabs. I'd be interested in tackling it but am not familiar with this project at all. Would anyone be willing to point me at a starting point?

edit: Looks like this PR fixes my woes: https://github.com/TypeStrong/atom-typescript/pull/1456

lierdakil commented 5 years ago

Looks like this PR fixes my woes: #1456

Right. I missed #315 when referencing issues in that PR (the backlog is a horrifying place, so I tend to avoid staring there too much)

lierdakil commented 5 years ago

V12.7.0 is released which includes experimental support for JS. It's a bit hacky at the moment, but it should work for the most part. See: https://github.com/TypeStrong/atom-typescript/blob/master/docs/faq.md#i-want-to-use-atom-typescript-with-javascript-too