Add multistep request completion event

TypeStrong / atom-typescript

The only TypeScript package you will ever need

https://atom.io/packages/atom-typescript

MIT License

1.13k stars 205 forks source link

Add multistep request completion event #1541

Closed firejune closed 4 years ago

firejune commented 4 years ago

[x] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)

TS version 2.2 added a protocol of RequestCompletedEvent. this event as detecting multistep operation and completion commands like geterr and geterrForProject. So I add little changes of callback system in Atom-Typescript for catching multistep completion.

It's expect more accurate latency in geterr and geterrForProject commands.

lierdakil commented 4 years ago

Thanks for the PR! I took the liberty of pushing here directly instead of doing the review proper (also did some old code clean-up). If you could look over the changes to make sure I didn't accidentally break anything and give me a go-ahead, that would be great! A short change summary is available in the extended commit description.

firejune commented 4 years ago

I think this is certainly a correct change in behavior 👍