[x] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)
takes out the loop invariant code
This snippet of the code is called tens or hundreds of times. Previously the number was multiplied by the number of diagnostics! If you can take this out from this nested loop, it would be better.
After
now after this PR pushError itself takes this much time, which is ~50ms faster in each call
takes out the loop invariant code
This snippet of the code is called tens or hundreds of times. Previously the number was multiplied by the number of diagnostics! If you can take this out from this nested loop, it would be better.![image](https://user-images.githubusercontent.com/16418197/88458603-d5565100-ce54-11ea-9676-75b369064eb4.png)
After
now after this PR pushError itself takes this much time, which is ~50ms faster in each call![image](https://user-images.githubusercontent.com/16418197/88458981-5c0c2d80-ce57-11ea-8401-cb6274888dab.png)
Before
Previously errorPusher took this much:![image](https://user-images.githubusercontent.com/16418197/88458949-12bbde00-ce57-11ea-8b8c-e28719fb6969.png)