fix(CommonJS idiom) Fixes directory references in CommonJS idiom

TypeStrong / dts-bundle

Export TypeScript .d.ts files as an external module definition

MIT License

308 stars 57 forks source link

fix(CommonJS idiom) Fixes directory references in CommonJS idiom #42

Closed kcjmowright closed 7 years ago

kcjmowright commented 8 years ago

Added fix to handle directory references in imports (CommonJS idiom) by assuming the file should be directory + index.d.ts
Added test.

Resolves Issue #38 @see https://github.com/TypeStrong/dts-bundle/issues/38

lifenautjoe commented 8 years ago

@Bartvds || @tolemac can someone take a look and hopefully approve this PR? Currently facing the issue this solves.

tolemac commented 7 years ago

I would like to have only changes related to the commit message in each commit. I think you would have to make a separate PR for fix the format (white spaces, new lines, ...)

Could you leave only changes related to the PR title?

kcjmowright commented 7 years ago

I'm a bit busy at the moment. I'll try to amend the commit in the next day or so.

tolemac commented 7 years ago

@kcjmowright Its good for now. I'm going to merge it and publish npm package. Thanks a lot.