search

TypeStrong / dts-bundle

Export TypeScript .d.ts files as an external module definition
MIT License
308 stars 57 forks source link

headerText option #47

Closed dmitry-kurmanov closed 7 years ago

dmitry-kurmanov commented 7 years ago

Hello! Thanks for your work! I've tried to use headerPath and separate file, but if I require/import something on it I get "require/import" in my header.

So I added the possibility to set the text for the header instead of path. Example of using: headerText: ["Type definitions for Survey JavaScript library v" + libraryVersion, "Project: http://surveyjs.org/", "Definitions by: Andrew Telnov <https://github.com/andrewtelnov/>"].join("\n") where libraryVersion is variable version from my package.json.

Could you check it please?

tolemac commented 7 years ago

LGTM!! I will merge it and will publish a new version on npm.

tsv2013 commented 7 years ago

@tolemac Super! Thank you! It's great feature! Can you merge it ASAP?

tolemac commented 7 years ago

Done! New 0.7.1 version abailable.

tsv2013 commented 7 years ago

@tolemac Great! Thanks!

dmitry-kurmanov commented 7 years ago

@tolemac , I've just upgraded the package to 0.7.1 but unfortunately there is no appropriate code in index.js file, but index.ts file contains it. Could you check it please? May be problem with build?

tolemac commented 7 years ago

I have just publish 0.7.2 version. Can you test it? Thank you very much!

dmitry-kurmanov commented 7 years ago

@tolemac it is ok now. Thank you!