search

TypeStrong / fork-ts-checker-webpack-plugin

Webpack plugin that runs typescript type checker on a separate process.
MIT License
1.94k stars 240 forks source link

Typo in README #455

Closed JoshRobertson closed 4 years ago

JoshRobertson commented 4 years ago

infastructure in logger default value should be infrastructure I assume?

piotr-oles commented 4 years ago

No, the default configuration is to not log infrastructure logs at all :)

JoshRobertson commented 4 years ago

No, the default configuration is to not log infrastructure logs at all :)

My comment is just that the word is spelled wrong on the README. it is written as infastructure which is incorrect. Normally I wouldn't comment but because it's a code snippet someone might copy and paste, it could be annoying.

piotr-oles commented 4 years ago

Ah, ok :) Would you like to create a PR?

JoshRobertson commented 4 years ago

Another typo:

diagnosticsOptions is wrong. the field in the code is diagnosticOptions