search

TypeStrong / fork-ts-checker-webpack-plugin

Webpack plugin that runs typescript type checker on a separate process.
MIT License
1.96k stars 239 forks source link

fix: bring back :line:col format in webpack errors #716

Closed robcrocombe closed 2 years ago

robcrocombe commented 2 years ago

Hello! In 2020 I opened an issue (#481) and subsequent PR (#489) to make error file names clickable with their line location intact, when you use cmd+click in a terminal like iTerm2. E.g. before it was filename.ts 12:5 but we changed it to filename.ts:12:5 to make it one item without space delimiters. This is a huge win for productivity as you don't need to hunt down the line number after opening the file.

I noticed while upgrading to v7 that this behaviour has been reverted by #641. It was mentioned in the GH issue that developer experience was more important than following Webpack convention. Has the stance changed on this or was it just a mistake?

If so, I've made this PR to bring back the clickable location behaviour. If not, is there another way we can fix this? I noticed there was a custom formatter option but that does not allow you to format the file name, and I still want to use codeframe. Thanks

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

piotr-oles commented 2 years ago

:tada: This PR is included in version 7.2.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

robcrocombe commented 2 years ago

Thanks @piotr-oles!