TypeStrong / fork-ts-checker-webpack-plugin

Webpack plugin that runs typescript type checker on a separate process.
MIT License
1.95k stars 240 forks source link

Clarify "No errors found." message #808

Open cben opened 1 year ago

cben commented 1 year ago

A really minor usability tweak, subjective, up to you if you like it.

In the context of webpack-dev-server, there are 2 async build processes, which may report success/failure:

There is sometimes a cyan "Type-checking in progress..." between them, but not always.

This PR tweaks the last case to say "No typescript errors found." for clarity.

Screenshot from 2023-10-29 15-42-45

piotr-oles commented 11 months ago

Maybe it would make more sense to just say "No typescript errors found."?

cben commented 11 months ago

Maybe it would make more sense to just say "No typescript errors found."?

Done, PTAL.

UPDATE: now also updated waitForNoErrors test helper. needs approval to re-run CI?