overlay: false not working - Githubissues

TypeStrong / fork-ts-checker-webpack-plugin

Webpack plugin that runs typescript type checker on a separate process.

MIT License

1.96k stars 239 forks source link

overlay: false not working #826

Closed is-harshul closed 1 year ago

is-harshul commented 1 year ago

Current behavior

Still able to see error in dev mode, even after adding the following config in webpack config.
```
devServer: {
hot: true,
client: {
  overlay: false,
},
},
```

Expected behavior

This error screen is expected to go away in dev mode.

Steps to reproduce the issue

Try passing:

devServer: {
    hot: true,
    client: {
      overlay: false,
    },
  },

in the config

Issue reproduction repository

It's a Private repo.

Environment

fork-ts-checker-webpack-plugin: ^8.0.0
typescript: ^5.2.2
eslint: ^8.45.0
webpack: ^5.88.2
os: macOS: 13.1

piotr-oles commented 1 year ago

It seems like a webpack configuration issue or a webpack bug. This plugin just reports issues that can be then consumed by the devserver and then displayed as an overlay. This plugin doesn't control overlay behaviour. It's a responsibility of the webpack-dev-server to respect the overlay: false option :)