TypeStrong / ts-loader

TypeScript loader for webpack
https://johnnyreilly.com/ts-loader-goes-webpack-5
MIT License
3.45k stars 428 forks source link

fix: add config file as build dependency #1611

Closed alexander-akait closed 1 year ago

alexander-akait commented 1 year ago

Make configuration more DX, we already known typescript configuration, so let's add it as a build dependency and not need provide to add this in build dependency like here https://github.com/TypeStrong/ts-loader/issues/1332

johnnyreilly commented 1 year ago

Builds passed - do you want to update the package.json / changelog.md?

alexander-akait commented 1 year ago

@johnnyreilly If need I can do, just don't know contirbution process, can you describe?

johnnyreilly commented 1 year ago

Change the version in the package.json to represent a new version - I'd say this is a patch rather than anything else.

The changelog.md is hopefully self explanatory - put a version entry in, linking back to this PR. Nothing more

alexander-akait commented 1 year ago

Change the version in the package.json to represent a new version - I'd say this is a patch rather than anything else.

The changelog.md is hopefully self explanatory - put a version entry in, linking back to this PR. Nothing more

Okay, I will do it, just thought that the release process is separate from the fixes/features, because we have https://github.com/TypeStrong/ts-loader/commit/5f28651df20ecd77cc8b1c70b4e8c33e18cee73b and I don't know what I should put in Changelog

johnnyreilly commented 1 year ago

So the changelog addition would probably be:

## 9.4.3
* [fix: add config file as build dependency](https://github.com/TypeStrong/ts-loader/pull/1611) - thanks @alexander-akait 
alexander-akait commented 1 year ago

@johnnyreilly Done :+1:

johnnyreilly commented 1 year ago

Publishing: https://github.com/TypeStrong/ts-loader/releases/tag/v9.4.3