TypeStrong / ts-node

TypeScript execution and REPL for node.js
https://typestrong.org/ts-node
MIT License
12.75k stars 529 forks source link

ERR_UNKNOWN_FILE_EXTENSION since Node.js 18.19.0 (works fine with 18.18.2) #2094

Open mlenkeit opened 7 months ago

mlenkeit commented 7 months ago

Search Terms

Expected Behavior

npx ts-node <script.ts> works on Node.js 18.19.0 just as it does with 18.18.2.

Actual Behavior

Since the upgrade to Node.js 18.19.0, the call fails with ERR_UNKNOWN_FILE_EXTENSION.

All other potentially related parameters remained unchanged (e.g. package-lock.json, ts-config.json, etc.).

We discovered this with GitHub workflow runs that run periodically (with schedule) at short intervals; only difference since things started failing is the Node.js version.

Steps to reproduce the problem

Minimal reproduction

see https://github.com/mlenkeit/ts-node-repro

there's also a GitHub workflow to run this repo against Node.js 18.19.0 and 18.18.2: https://github.com/mlenkeit/ts-node-repro/actions/runs/7057725777

Specifications

michael42 commented 7 months ago

Workaround: You can use node --loader ts-node/esm file.ts instead of ts-node --esm file.ts (which causes a ExperimentalWarning: --experimental-loader may be removed in the future). It would be great if ts-node provided an entrypoint that calls register from node:module, which seems to be Node's preferred way of registering loaders, now.

mlenkeit commented 7 months ago

@michael42 thanks for the suggestion. This indeed works with both Node.js 18.18.2 and 18.19.0.

I will, however, hold back with applying that change for now, as this would require changes across a dozen or so repos. We've simply pinned Node.js to 18.18.2 for now to unblock us.

I still consider this to be a bug in ts-node.

jetwiwo commented 7 months ago

Same issue in node v20.10.0 (current LTS)

JonWallsten commented 7 months ago

Workaround: You can use node --loader ts-node/esm file.ts instead of ts-node --esm file.ts (which causes a ExperimentalWarning: --experimental-loader may be removed in the future). It would be great if ts-node provided an entrypoint that calls register from node:module, which seems to be Node's preferred way of registering loaders, now.

This does not seem to work for me: node --loader ts-node/esm -r tsconfig-paths/register ./scripts/deploy.ts

(node:129) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
/builds/ci-vct-dev/aws-platform-ci/aws-cdk/scripts/deploy.ts:1
import { AWS_DOMAIN } from '../shared-lib/src/environment/compile';
^^^^^^
jetwiwo commented 7 months ago

Workaround: You can use node --loader ts-node/esm file.ts instead of ts-node --esm file.ts (which causes a ExperimentalWarning: --experimental-loader may be removed in the future). It would be great if ts-node provided an entrypoint that calls register from node:module, which seems to be Node's preferred way of registering loaders, now.

This does not seem to work for me: node --loader ts-node/esm -r tsconfig-paths/register ./scripts/deploy.ts

(node:129) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
/builds/ci-vct-dev/aws-platform-ci/aws-cdk/scripts/deploy.ts:1
import { AWS_DOMAIN } from '../shared-lib/src/environment/compile';
^^^^^^

Make sure you have "type": "module" in package.json or rename the file to file.mts

mlenkeit commented 7 months ago

Same issue in node v20.10.0 (current LTS)

@jetwiwo right, thanks for mentioning that. FWIW, it looks like it doesn't work with Node.js 20 at all. I've added Node.js 20 versions to the repo for reproducing the problem.

image

https://github.com/mlenkeit/ts-node-repro/actions/runs/7125070507

ajvincent commented 7 months ago

See #1997 - this sounds like a duplicate of that one.

mlenkeit commented 7 months ago

See #1997 - this sounds like a duplicate of that one.

I agree that #1997 and this one probably share the same root cause.

Yet, I think they differ in their implication: If ts-node changed the way it works on a major version bump of Node.js, I'd say that's acceptable. But if ts-node suddenly stopped working on a minor version bump of Node.js, I'd say it's a bug.

MythicManiac commented 7 months ago

Got bit by this just a few minutes ago as well, would agree with not expecting breaking changes with minor version bumps.

rreeves8 commented 7 months ago

Does anyone know which version of node it works on ? Currently have this issue with node 20, running ts-node --esm in a module

rcollette commented 7 months ago

I'm using tsx with AWS CDK until this is resolved.

In cdk.json, change the app property to:

  "app": "npx tsx bin/app.ts",
mlenkeit commented 7 months ago

Does anyone know which version of node it works on ? Currently have this issue with node 20, running ts-node --esm in a module

@rreeves8 it works on Node.js 18.18.2. To my knowledge, any newer version runs into the problem described here (incl. Node.js 20). For following this kind of problem for Node.js 20, you may want to take a look at #1997 as well.

kuncevic commented 6 months ago

node --loader ts-node/esm index.ts works for me

seemrcola commented 6 months ago

Workaround: You can use node --loader ts-node/esm file.ts instead of ts-node --esm file.ts (which causes a ExperimentalWarning: --experimental-loader may be removed in the future). It would be great if ts-node provided an entrypoint that calls register from node:module, which seems to be Node's preferred way of registering loaders, now.

This does not seem to work for me: node --loader ts-node/esm -r tsconfig-paths/register ./scripts/deploy.ts

(node:129) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
/builds/ci-vct-dev/aws-platform-ci/aws-cdk/scripts/deploy.ts:1
import { AWS_DOMAIN } from '../shared-lib/src/environment/compile';
^^^^^^

Make sure you have "type": "module" in package.json or rename the file to file.mts

thanks, it works for me

mlenkeit commented 6 months ago

FWIW, we have decided to switch to tsx, given that there hasn't been any reaction yet from the maintainers of ts-node.

In addition to replacing the dependency itself, we have removed the ts-node config from our tsconfig.json file and also uninstalled any explicit dependencies to swc (if present), as it seems to be the default in tsx.

We struggled a bit to make it work across Node.js versions, given that the --loader and --import options seem to be mutually exclusive, and ended up having dedicated scripts in our package.json.

sovietspaceship commented 3 months ago

Any update on this? This has rendered ts-node completely unusable and not fit for purpose. The node --loader ts-node/esm file.ts and similar workarounds do not always work, and break all existing projects that now have to temporarily implement the workaround while this gets fixed.

qiulang commented 2 months ago

The other workaround is to use tsx instead. tsx also comes with watch mode, which is a bonus.