Importing nodejs types pollutes global types - Githubissues

TypeStrong / tsify

Browserify plugin for compiling TypeScript

344 stars 75 forks source link

Importing nodejs types pollutes global types #267

Closed falsandtru closed 4 years ago

falsandtru commented 4 years ago

You are importing browserify, and browserify imports nodejs: https://github.com/TypeStrong/tsify/blob/6b7a4f1a94ebd891bd8b4d53d1e82deb0a767edc/index.d.ts#L1

This makes type errors https://github.com/DefinitelyTyped/DefinitelyTyped/issues/22510. Can you remove that import?

cartant commented 4 years ago

Removed in 5.0.2.

falsandtru commented 4 years ago

thx