search

TypeStrong / tsify

Browserify plugin for compiling TypeScript
344 stars 75 forks source link

Fix broken type-declaration #279

Closed manuth closed 3 years ago

manuth commented 3 years ago

The current type-declaration export default function tsify(...) suggests that a default export is present in the corresponding javascript. But tsify doesn't actually use a module.exports.default = function tsify(...) or export default function tsify(...) as seen here: https://github.com/TypeStrong/tsify/blob/437e5b51fce8dfc3c92c218ee66633dc71a7d3ef/index.js#L96

For that reason, this module currently can't be consumed correctly using typescript.

This PR fixes the described issue.

manuth commented 3 years ago

Thanks. The export needs to be removed from interface Options, but I'll do that in a separate commit.

Oooh I'm sorry, I totally forgot about that.

Thanks a ton for the effort!

cartant commented 3 years ago

Thanks. 5.0.4 has been published.