TypeTogether / Playpen-Sans

TypeTogether Playpen Sans font.
SIL Open Font License 1.1
37 stars 2 forks source link

Overall Latin / Cyrillic / Greek / SSA review #18

Open emmamarichal opened 2 months ago

emmamarichal commented 2 months ago

Hi @josescaglione, cc @vv-monsalve @chrissimpkins @davelab6

Viv generated a lot of proofs to check, for each languages. I put here a first review (mainly outlines and anchors). Review done on Google Chrome / Mac

Playpen_review_180924.pdf

I'll complete that issue with my review on Windows. cheers!

vv-monsalve commented 2 months ago

@josescaglione This PDF corresponds with the one I sent you yesterday and the round 1 proofs produced at commit 13ffdf3 Update fea RightToLeft lookup flag.

As we discussed during yesterday's meeting, some reported issues might have already been solved since you continued working on the fonts.

josescaglione commented 2 months ago

Thanks, we will review, no problem

vv-monsalve commented 2 months ago

I'll continue adding here the feedback for the LGC and SSA as I receive it.

josescaglione commented 2 months ago

I have a few comments in the PDF, We are missing several text strings we need to sort this out.

Playpen_review_180924.pdf

vv-monsalve commented 2 months ago

Some answers to the PDF notes:

josescaglione commented 2 months ago

chook.alt3 is a 2-stroke construction of the glyph. It was drawn like this purposedly. If you want it changed we are still on time, just let us know.

josescaglione commented 2 months ago

@vv-monsalve As far as I understand all of the fixable issues are fixed in the latest version, we even added basic lc to UC kerning. We can go over anything that you consider still open together in a call to make things easier

vv-monsalve commented 2 months ago

@josescaglione Great. However, I'll keep bringing to the issue tracker the feedback provided by all the reviewers before creating round 2 of proofs.

vv-monsalve commented 2 months ago

Hi, @josescaglione, I'm bringing here the feedback provided by @kosbarts on LGC.

PPS-Review-Kostas 092324.pdf

This PDF corresponds with the one he sent you by email. Kostas reported he used a more updated font you provided him, so I can't track the commit to which that font belongs.

Some reported issues might have already been solved since you continued working on the fonts.

josescaglione commented 2 months ago

Hi @vv-monsalve the issues raised by Kostas in Greek and LATX were sorted out. We will review the arabic and cyr ones

josescaglione commented 2 months ago

Update, the issue spotted by Kostas about Arabic shaping for Kurdish has been fixed

Screenshot 2024-09-24 at 15 31 51

vv-monsalve commented 1 month ago

Hi @josescaglione, I'm bringing here the feedback provided by @MariannaPaszkowska for the at commits:

PPS-LGC-SSA-Marianna.pdf