Closed josescaglione closed 1 year ago
The new VM at 1.68 UPM looks better but is still a bit loose. Testing it with the Icons included we think it could be reduced to the ~1.5 and have enough room for vertical needs like Vietnamese marks.
Current - Proposed VM comparison
Proposed values:
@vv-monsalve Updated vertical metrics to your proposed values
@vv-monsalve please close when verified
I'll leave this issue open while we are reviewing VMs for the big Playpen.
After a final revision with @josescaglione to the vertical metrics the new agreed values should be:
Comparative image between current and new values:
Font pulled at commit 2ddc98e
has the agreed VM values.
@casasin after pulling the latest files at commit 750ba63
, the font no longer has the agreed VM values, and we have now a new Fail reported.
@casasin after pulling the latest files at commit
750ba63
, the font no longer has the agreed VM values, and we have now a new Fail reported (…).
@vv-monsalve Somehow rolled back in some source update. They are fixed in latest commit. I hope that's all 🤞🏽
@casasin They are working now, thanks. Could you please turn the repository public? This is needed to create the PR to GF.
@vv-monsalve : the repo is now public.
Thank you
As a result of the discussion regarding the vertical metrics we had with @vv-monsalve I tightened the double accents in Pinyin and Viet glyphs. Additionally I replaced our default y by y.ss01 in the ydotbelow glyph, which saves lots of vertical space as it was the deepest character in the font.
In order for the randomizer to work correctly the ccmp entry for ydotbelow must be changed from
sub ydotbelow by y dotbelowcomb;
to:sub ydotbelow by y.ss01 dotbelowcomb;