TypeTogether / Playpen-Sans

TypeTogether Playpen Sans font.
SIL Open Font License 1.1
35 stars 2 forks source link

ccmp code change and vertical metrics #4

Closed josescaglione closed 1 year ago

josescaglione commented 1 year ago

As a result of the discussion regarding the vertical metrics we had with @vv-monsalve I tightened the double accents in Pinyin and Viet glyphs. Additionally I replaced our default y by y.ss01 in the ydotbelow glyph, which saves lots of vertical space as it was the deepest character in the font.

In order for the randomizer to work correctly the ccmp entry for ydotbelow must be changed from sub ydotbelow by y dotbelowcomb; to: sub ydotbelow by y.ss01 dotbelowcomb;

vv-monsalve commented 1 year ago

The new VM at 1.68 UPM looks better but is still a bit loose. Testing it with the Icons included we think it could be reduced to the ~1.5 and have enough room for vertical needs like Vietnamese marks.

Current - Proposed VM comparison VM-diff-15-16

Proposed values:

Screen Shot 2023-06-22 at 21 01 10
casasin commented 1 year ago

@vv-monsalve Updated vertical metrics to your proposed values

davelab6 commented 1 year ago

@vv-monsalve please close when verified

vv-monsalve commented 1 year ago

I'll leave this issue open while we are reviewing VMs for the big Playpen.

vv-monsalve commented 1 year ago

After a final revision with @josescaglione to the vertical metrics the new agreed values should be:

Screen Shot 2023-08-22 at 11 08 40

Comparative image between current and new values:

diffbrowsers_text-macOS-12 6 3-x86_64-i386-64bit_chrome_116 0 5845 96

vv-monsalve commented 1 year ago

Font pulled at commit 2ddc98e has the agreed VM values.

vv-monsalve commented 1 year ago

@casasin after pulling the latest files at commit 750ba63, the font no longer has the agreed VM values, and we have now a new Fail reported.

Screen Shot 2023-09-06 at 14 40 46
casasin commented 1 year ago

@casasin after pulling the latest files at commit 750ba63, the font no longer has the agreed VM values, and we have now a new Fail reported (…).

@vv-monsalve Somehow rolled back in some source update. They are fixed in latest commit. I hope that's all 🤞🏽

vv-monsalve commented 1 year ago

@casasin They are working now, thanks. Could you please turn the repository public? This is needed to create the PR to GF.

casasin commented 1 year ago

@vv-monsalve : the repo is now public.

vv-monsalve commented 1 year ago

Thank you