Closed Chemaclass closed 3 months ago
Can i work on it ?
Great to see you back here again, @gpuligundla !
Of course, would you mind waiting a bit before starting it? We want to make some small changes to your last contribution that might affect the way to solve this issue.
When we make the changes, we'll let you know so that you can take a look at them too and then you can start this one. Meanwhile, I'll go ahead and assign it to you. 😊
@gpuligundla we already merged #227 so you can start this issue when you want 😃
Actually, I think we should copy/paste the helpers::get_latest_tag()
function entirely in the install.sh
script, because it must be a fully independent script, as it it what the users will download (as single script) to install bashunit. So we cannot source/load other scripts within the installer.
I would like to work on this, please assign this issue to me.
@maheshmeleti sure, thank you!
@maheshmeleti let us know if you need help with this
@Chemaclass im still working on it
Current
When creating a new release, we have to change the release version in many files (see
.github/RELEASE.md
). However, currently theinstall.sh
is one of them and that's creating a downtime when we are creating a new release - during the time when this change it's pushed and the actual new release is created, the installer tool wont work.Expected
Instead of using a hardcoded version on
install.sh
, we should get the latest stable version. In this PR, we introducedget_latest_tag()
and we could use it oninstall.sh
script instead of a hardcoded version.