Multiline strings are passes as multiple args to assert_line_count which makes it complicated to pass around and manipulate as unique string.
🔖 Changes
assert_line_count uses first arg for the expected and the rest (think about a variadic ...string arg) will be the string itself that will be use to count its lines.
💡 Extra
Tradeoff: I had to rollback https://github.com/TypedDevs/bashunit/pull/262 in order to make it working. I think I can make it back again, but it might take another couple of hours... so, I thought to ship this first, make it work, and then in a follow up make it better.
📚 Description
Issue: https://github.com/phpstan/phpstan-src/pull/3160#discussion_r1643902055
Multiline strings are passes as multiple args to
assert_line_count
which makes it complicated to pass around and manipulate as unique string.🔖 Changes
assert_line_count
uses first arg for the expected and the rest (think about avariadic ...string arg
) will be the string itself that will be use to count its lines.💡 Extra
Tradeoff: I had to rollback https://github.com/TypedDevs/bashunit/pull/262 in order to make it working. I think I can make it back again, but it might take another couple of hours... so, I thought to ship this first, make it work, and then in a follow up make it better.