Error when trimming - Githubissues

TypesettingTools / Aegisub-Motion

Lua plugin for Aegisub auto4 that parses motion tracking data and applies it to selected subtitles.

Other

172 stars 23 forks source link

Error when trimming #16

Closed powerunlimited closed 9 years ago

powerunlimited commented 9 years ago

gives me this error whenever I try to trim anything

Lua reported a runtime error: File "E:/sub\aegisub-3.2.1-portable-32\automation\autoload\Aegisub-Motion.moon", line 483 <anonymous function at lines 457-485> File "E:/sub\aegisub-3.2.1-portable-32\automation\include\a-mo\TrimHandler.moon", line 128 performTrim File "E:/sub\aegisub-3.2.1-portable-32\automation\include\a-mo\TrimHandler.moon", line 95 execFunc attempt to index local 'logFile' (a nil value)execFunc

the command prompt does appear but complains about a wrong file path and then disappears FYI: I'm running the latest aegisub 3.2.1(portable), Win8.1(non english OS) I have heard that win8.1 doesn't like short paths? maybe that's the culprit?

torque commented 9 years ago

I can't reproduce it with a quick try (I only have win7 to test on). I will add handling for that error but I don't know what's causing it. The script gets the logfile path from Aegisub, so it should be valid.

torque commented 9 years ago

I am not sure if test10 that I just released will fix your problem, but give it a try. At the very least it should pop up a proper error now.

powerunlimited commented 9 years ago

OK, I gave test 10 a try, and no luck.

After some googling and trial & error, I think I found the culprit and a solution

The main problem was the non Latin characters in the log file path (Some M$ developer thought a user path with non Latin characters was a ~~good~~ idea) ex."良泰"
This happens more often in win8, win8.1 because M$ encourages you to use your real name or M$ live id as the username for your account (especially with non-English OS)

solution

change the log file path to %localappdata%\Temp\a-mo.encode.log

Hope this Helps~ Also thanks a lot for creating this magical script, without it TS moving signs would be a time killer

torque commented 9 years ago

Since I don't have a great way to test this, if I could use you as a guinea pig that would be fabulous.

If you could replace your automation/include/a-mo/TrimHandler.moon with the one I just updated (here is a link) and tell me if that solves the problem, that would be great.

It's an alternate solution to the one you suggested, and may actually be able to fix more legacy problems—if it actually works.

powerunlimited commented 9 years ago

OK so it works now no errors or such

FYI: something came up in the cmd line that doesn't seem to belong there, does no harm though