search

TypesettingTools / Aegisub-Motion

Lua plugin for Aegisub auto4 that parses motion tracking data and applies it to selected subtitles.
Other
174 stars 24 forks source link

x264 compatibility #2

Closed SchRita closed 10 years ago

SchRita commented 10 years ago

I'm a noob so I'm sorry if I ask something that's not your job to fix. But for some reason, when I try to use the x264 encode binaries (releases starting from x264-r2356-a1d3d17), the encoder opens and closes, and does nothing. I think there's something wrong with the command line, because the command bat file is created and runs, but I don't get any video files in the folder. This version: x264-r2345

->that I got from here: http://www.digital-digest.com/software/download-997_0_282_file_x264.exe%2B%252832-bit%2529.html

does the thing, and the ones before it, too (although I only checked one previous version except this one). The official r2345 (from the official site) doesn't work either. If you need more information, feel free to contact me.

And in the meantime, thanks for making this awesome tool.

torque commented 10 years ago

I will investigate this when I have some time. The cmd window should pause open if the x264 process errors instead of running successfully. If that's not happening and you're still not getting a video output, then there's probably something else going wrong somewhere.

helloitszak commented 10 years ago

I don't know if anything ever came of this, but I was having the same issue. The version of x264.exe I was using wasn't compiled with mp4 output support. The build I had was from here. The cmd window opens for a split second and closes. Was able to get at the actual error by removing the del %0 from the batch and replacing it with a pause. The latest from here worked like a charm.

torque commented 10 years ago

I'm suspicious that this problem was related to the fix in commit d82b10717a, which caused everything to be written to the wrong directory, and caused x264 to fail in certain cases.

Though it may have been caused instead by the problem fixed in 33bb554051, which was apparently causing random errors when trying to encode on Windows for some people.

What I'm trying to say is, I think the problem that was causing this error got fixed. At some point, the error reporting for encoding failures will be made more robust.