search

TypesettingTools / Aegisub-Motion

Lua plugin for Aegisub auto4 that parses motion tracking data and applies it to selected subtitles.
Other
172 stars 23 forks source link

Simple Fad Fix #36

Closed conkererer closed 7 years ago

conkererer commented 7 years ago

Still really confused whether \fade(n1,n2) is valid or not since the regex used in Tags.moon and elsewhere is "\fade?%((%d+,%d+)%)", so that might be an error

These changes are kinda tested, probably work fine, but would maybe make processing by other script harder since \fade tags are not used that often

conkererer commented 7 years ago

The \fade(n1,n2) error in MotionHandler is not actually getting thrown in the current master since it converts it into a transform

torque commented 7 years ago

Still really confused whether \fade(n1,n2) is valid or not since the regex used in Tags.moon and elsewhere is "\fade?%((%d+,%d+)%)", so that might be an error

That was in there because while that tag is erroneous, I received multiple complaints that aegisub-motion wasn't working correctly from people who, unfamiliar with the inner horror of ASS or simply illiterate, had used \fade(100,100) instead of \fad(100,100). I decided it was a better solution to steamroll this mistake than to ignore it or have it cause an error.

conkererer commented 7 years ago

90% functional, only bug left is fixing the way it gets alpha values in the first block couldn't figure out how to get the Line functions to work properly in the MotionHandler, dunno if that's broken or something

Tests: http://y.zxq.co/lmjnba.ass https://paste.ee/p/O2iNW

conkererer commented 7 years ago

Made some improvements to roto handling while I was at it, even though it seems I'm the only one that uses this feature

torque commented 7 years ago

The pull request name is as appropriate as ever. Thanks for doing all the work.

I don't see any obvious problems, but I'm going to squash this down into only a few commits before merging it.