search

TypesettingTools / Aegisub-Motion

Lua plugin for Aegisub auto4 that parses motion tracking data and applies it to selected subtitles.
Other
175 stars 24 forks source link

Add easy @lines access and update runCallback #37

Closed CoffeeFlux closed 7 years ago

torque commented 7 years ago

I'm just going to bump this to say that you never gave me a test case where my suggested implementation didn't work.

Also, I can't remember if we talked about this, but it would reduce the amount of nasty implementation to use the __call method instead. The only downside of this is that access and assignment would become asymmetrical, but that's not really my problem.

In the interest of convenience, it may also be worth it to implement __pairs. I think luajit in 5.2 compatibility mode supports this.

torque commented 7 years ago

you are extremely ugly and bad

CoffeeFlux commented 6 years ago

Commits are updated, not using call, and including pairs and ipairs. If you could reopen this that'd be lovely. Happy Valentine's Day! edit: Apparently that's not possible, so a new pull request was opened.