search

TypesettingTools / Aegisub-Motion

Lua plugin for Aegisub auto4 that parses motion tracking data and applies it to selected subtitles.
Other
172 stars 23 forks source link

Correctly handle edge case of empty selection for LineCollection #47

Closed CoffeeFlux closed 5 years ago

CoffeeFlux commented 5 years ago

As-is, this will not ever generate styles and there is no specified behavior on where inserted lines will appear. Either ban the behavior or, as part of documentation, make clear how it works.

CoffeeFlux commented 5 years ago

I believe that with https://github.com/TypesettingTools/Aegisub-Motion/commit/1a9d284a5f21e9def137c2903dcc540064f7a884 this is reasonably clear in the code. Styles will properly be generated, and lines will be inserted at the beginning of the script. This should be documented, along with the rest of the library, but that's out of scope for this issue.