TypesettingTools / Aegisub

Cross-platform advanced subtitle editor
http://www.aegisub.org
Other
322 stars 489 forks source link

Find / Find and Replace duplication behavior with Skip Override Tags #52

Open OrangeChannel opened 5 years ago

OrangeChannel commented 5 years ago

correct-behavior-noskip This is the expected behavior, one find and the proper location. . . . correct-replace-all Same situation here, works as expected. . . . But, with Skip Override Tags ticked and an override tag in the line, it does this: bug-skip bug-skip-second-find It finds two locations, which isn't necesarily bad if it was just a visual bug. But this affects Find and Replace which is a larger issue. incorrect-replace-all


Interestingly, if the tag length is longer than the text before the Find word, it doesn't result in this bug. This can be seen here: too-short-maybe (it only finds one "of") But, it's not the tag length itself bugging it out, it can work with any tag length, as long as the search word is after some text longer than the tag. long-tags-too


Steps to reproduce:

wangqr commented 4 years ago

This should have been fixed in Aegisub/Aegisub@7a1756a26f4a67656034e70c5ab81f8526617a32