search

TypesettingTools / Myaamori-Aegisub-Scripts

Overengineering is my middle name.
MIT License
37 stars 7 forks source link

Fontvalidator does not properly parse mkv #17

Open McBaws opened 2 years ago

McBaws commented 2 years ago

When using fontvalidator directly on mkv files, it will not properly detect either the font files or the sub track. Instead, it will only say 'Ignoring non-font attachment FONT.ttf' for each font, and nothing else. The fact it does not give missing font errors when run also implies that it is not detecting the subtitle tracks correctly either.

The solution I found for both of these was removing the "b" from "b'S_TEXT/ASS':" on line 333 and removing all of the "b"s from before the strings in the FONT_MIMETYPE set on lines 388-396. The script worked perfectly for me after removing these. I'm guessing these stopped the script from properly detecting the font filetype or the tracks which were subtitles.

Animorphs commented 2 years ago

Same issue here, pull request #15 also fixes it