search

TyphoonMC / TyphoonLimbo

Lightweight minecraft limbo server
GNU General Public License v2.0
91 stars 13 forks source link

Can't figure out how to use velocity Modern forwarding? Is it even supported? #30

Open chexo3 opened 5 years ago

chexo3 commented 5 years ago

Nowhere in config to put the secret, would not connect in modern forwarding mode.

skyforce77 commented 5 years ago

Are you talking about this project ? https://github.com/VelocityPowered/Velocity

I wasn't aware of it so it isn't supported.

astei commented 5 years ago

I'll provide a potted explanation as to why TyphoonCore doesn't work with Velocity's modern forwarding:

Velocity's "modern" forwarding is based on the Login Plugin Request and Login Plugin Response messages. The message that Velocity sends is documented here.

In this case, the easiest fix is to have TyphoonCore support receiving these messages (which are new in 1.13) and simply respond that it doesn't know if the server doesn't know how to handle them.

chexo3 commented 5 years ago

Ok. It's mainly just because velocity doesn't currently support different forwarding methods for different services. If I want to use Modern forwarding for my backend servers, which I do, I have to use it for all of them, including Limbo.

skyforce77 commented 5 years ago

Thanks @astei. I'll try to add support for these messages.

In fact, TyphoonLimbo (TyphoonCore to be precise), has its core based on the 1.10 protocol and the others are only translations of the existing packets.

It will be a bit tricky to do, but I think I can manage to handle it correctly.

chexo3 commented 5 years ago

Thanks for your help.

mikroskeem commented 5 years ago

Any updates on this?

mikroskeem commented 5 years ago

Really experimental and hacky version of core is here, feel free to try it out: https://github.com/mikroskeem/TyphoonCore/tree/velocity-support

Ideally, TyphoonCore should wait for Login Plugin Response before sending additional packets to players, so final implementation is up to project author(s).

chexo3 commented 5 years ago

Can you attempt a PR maybe?

mikroskeem commented 5 years ago

To PR this, TyphoonCore logic must be changed as well. I don’t like this solution at all, even though it works.

On 10 Jun 2019, at 01:14, chexo3 notifications@github.com wrote:

Can you attempt a PR maybe?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

chexo3 commented 5 years ago

Oh. That's unfortunate.

skyforce77 commented 5 years ago

Hi, I was on holidays without any computer.

To PR this, TyphoonCore logic must be changed as well. I don’t like this solution at all, even though it works. … On 10 Jun 2019, at 01:14, chexo3 @.***> wrote: Can you attempt a PR maybe? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

That's exactly why I will not provide any support for Velocity. I'm currently thinking about the possibility to have new members working on Typhoon projects. I don't have so much time to do more than updating without any new features.

astei commented 5 years ago

Velocity itself will work just fine with TyphoonCore, only Velocity's custom IP forwarding won't work. Legacy forwarding should be fully supported as it's the same protocol used by BungeeCord.

parkervcp commented 5 years ago

From my testing Legacy is also failing currently.