search

TypicalAM / goread

Beautiful program to read your RSS/Atom feeds right in the terminal!
GNU General Public License v3.0
411 stars 16 forks source link

feat: feed order flag #31

Closed jarreed0 closed 1 year ago

jarreed0 commented 1 year ago

This feature adds a way to list the feed in chronological (default) or reverse chronological order using the order/o flag.

TypicalAM commented 1 year ago

Hi! There's two things I don't quite get about this solution. The first is that there are three types of ordering [chronological reverse-chronological reverse] but yet they converge into a binary option while initializing the backend. I wouldn't have anything against doing something like throwing the "already read" articles at the end but I don't quite get the reverse order use case.

jarreed0 commented 1 year ago

I was trying to make it so older articles appeared last. reverse was supposed to just be a shortened version of reverse-chronological. I guess my main issue was that my RSS subscriptions have articles from years ago and when I open the app they are at the very top when I would rather look at articles from today first, so I was trying to make a flag to sort this way. There's probably a better implementation as I haven't been able to read through all the code yet.

If you have any suggestions on how to do so I would be really grateful. Thanks

TypicalAM commented 1 year ago

Actually noticed that when sorting articles in the "All Articles" section, they would be sorted oldest first, not newest. I modified articlesToSuccessMsg to just sort the articles newest first when displaying them, so that would fix the issue. I didn't notice that the newest wouldn't appear first before. No need for a special flag