Typositoire / concourse-helm3-resource

Concourse resource to deploy Helm v3 charts.
35 stars 62 forks source link

Set helm upgrade history-max to 10 releases #100

Closed ThibaultDelaune-pro closed 8 months ago

ThibaultDelaune-pro commented 1 year ago

Helm has this option set to 10 by default (cf. https://helm.sh/docs/helm/helm_upgrade/). So why setting another value in this concourse resource?

The problem is that in my organisation, nobody overwrite this setting and we have thousands of helm secrets persisting...

ThibaultDelaune-pro commented 1 year ago

maybe the best option would be to let the helm default value and set the resource default value to "" (since if empty upgrade_args is not set)...

roux-jerome commented 1 year ago

@Typositoire an other intersting pull request

Tang8330 commented 8 months ago

Agreed, nice feature.

Tang8330 commented 8 months ago

@Typositoire Looks like CI checks are hanging and there's no way to bypass.

Typositoire commented 8 months ago

Concourse: Version bump found.