search

Typositoire / concourse-helm3-resource

Concourse resource to deploy Helm v3 charts.
35 stars 62 forks source link

adding `diff_opts` to allow adding aditional `helm diff` options. #125

Closed duxing closed 2 months ago

duxing commented 2 months ago

this can be helpful in situations where you have to add additional options to diff command.

e.g. if your helm chart contains lookup function, you need to specify --dry-run=server to diff command (context)

with diff_opts, it can be supported easily as the example in README.md

duxing commented 2 months ago

hi @Tang8330 ! can you take a look at this short PR when you have a chance?

duxing commented 2 months ago

@Typositoire can you take a look if you have a chance?

Tang8330 commented 2 months ago

Sorry @duxing, code lgtm

duxing commented 2 months ago

@Tang8330 sry I forgot to bump version, can you re-review?

duxing commented 2 months ago

@Tang8330 sry to bother you again, if it's okay to you, can you help me merge the PR?

Only those with write access to this repository can merge pull requests.