search

Typositoire / concourse-helm3-resource

Concourse resource to deploy Helm v3 charts.
35 stars 62 forks source link

Remove purge option when deleting a chart as helm3 does it by default and include namespace. #17

Closed erathinam closed 4 years ago

erathinam commented 4 years ago

Hi, Creating this issue to fix two things. 1) Helm 3 removed the option of purging a delete and now it is done by default. ISSUE: https://github.com/helm/helm/issues/5804. 2) Also, since the releases can be installed in different namespaces, helm delete should take the namespace as a flag else it won't find it cause it checks the default namespace. These two fixes requires changing the out.sh and README.md.

@Typositoire I would be happy to contribute to this by creating a PR. :) Let me know your thoughts. Great work!!

Typositoire commented 4 years ago

PR away! ;-)

Typositoire commented 4 years ago

Confinement is really hard for me lots of stuff and less time to do work on my own with kids 24/7 at home ! All help is welcome!

erathinam commented 4 years ago

No problem. Il Start working on this and create a PR. :)