Tyriar / vscode-shell-launcher

VS Code extension that enables easy launching of multiple shell configurations in the terminal
https://marketplace.visualstudio.com/items?itemName=Tyriar.shell-launcher
MIT License
49 stars 9 forks source link

Added support for a `cwd` setting #17

Closed fabiospampinato closed 6 years ago

fabiospampinato commented 6 years ago

Fixes https://github.com/Tyriar/vscode-shell-launcher/issues/12

Tyriar commented 6 years ago

Thanks @fabiospampinato, sorry about the delay

Tyriar commented 6 years ago

@fabiospampinato does this work for you? Testing it out with:

"shellLauncher.shells.osx": [
    {
      "shell": "/bin/bash",
      "label": "bash",
      "cwd": "/home/daimms/dev"
    }
]

I'm seeing a chdir error in the terminal and then this:

screen shot 2018-03-30 at 8 24 57 am
fabiospampinato commented 6 years ago

It wasn't working for me either beucase of https://github.com/Tyriar/vscode-shell-launcher/pull/18.

I think you're getting that error because /home/daimms/dev doesn't exists, should we check for that?

Tyriar commented 6 years ago

I think you're getting that error because /home/daimms/dev doesn't exists

Oh yeah, I'm on my mac not Linux box, haha. It couldn't hurt to show a nicer error message.

fabiospampinato commented 6 years ago

It couldn't hurt to show a nicer error message.

Perhaps this check should be added in VSC itself? 🤔

Tyriar commented 6 years ago

https://github.com/Microsoft/vscode/issues/17450 :smile: