search

Tyriar / vscode-sort-lines

Visual Studio Code extension to sort lines of text
https://marketplace.visualstudio.com/items/Tyriar.sort-lines
MIT License
146 stars 42 forks source link

Sorting of complex propTypes spoils the syntax #89

Closed boonya closed 3 years ago

boonya commented 3 years ago

2021-02-12 18 20 42

The initial state

    id: PropTypes.string.isRequired,
    title: PropTypes.string.isRequired,
    video: PropTypes.shape({
        en: PropTypes.string.isRequired,
        fr: PropTypes.string.isRequired,
    }).isRequired,
    onClick: PropTypes.func.isRequired,

Expected result

    id: PropTypes.string.isRequired,
    onClick: PropTypes.func.isRequired,
    title: PropTypes.string.isRequired,
    video: PropTypes.shape({
        en: PropTypes.string.isRequired,
        fr: PropTypes.string.isRequired,
    }).isRequired,

Actual result

        en: PropTypes.string.isRequired,
        fr: PropTypes.string.isRequired,
    }).isRequired,
    id: PropTypes.string.isRequired,
    onClick: PropTypes.func.isRequired,
    title: PropTypes.string.isRequired,
    video: PropTypes.shape({
Tyriar commented 3 years ago

Sorting requiring language smarts is out of scope for this extension

boonya commented 3 years ago

Fair enough. Thank you for your answer.