Tyriar / vscode-terminal-here

VS Code extensions that creates an integrated terminal session at the current file's directory
https://marketplace.visualstudio.com/items?itemName=Tyriar.vscode-terminal-here
33 stars 11 forks source link

Change Windows drive #4

Closed JoePue closed 6 years ago

JoePue commented 7 years ago

If I have a file "E:\testdir\test.txt" and i want open a terminal on this drive in this folder, then your extension works not correctly, because your extension will not change the drive by enter "E:". Actually the executed command "cd E:\testdir" is not enough for windows. Could you please extend your extension and support different windows drives. Best regards Joe

JoePue commented 7 years ago

How can I help you? (I'am not really understood the 'help wanted' tag)

Tyriar commented 7 years ago

I'm open to accepting a PR, you would need to add some special logic for Windows in https://github.com/Tyriar/vscode-terminal-here/blob/master/src/extension.ts to check if there is a drive letter.

noman9607 commented 5 years ago

Are you new? This is simple, just use the /d flag like this: "CD /D path-filename". We are talking dos 2 or 3, like the early eighties. Type cd /? in your console window and read all about it. There is no penalty for using the d flag when you do not need it. This is how I edit your command so that it will work.

Tyriar commented 5 years ago

@noman9607 feel free to make a PR to improve it, lose the attitude though.