Tyriar / vscode-windows-terminal

VS Code integration with Windows Terminal
https://marketplace.visualstudio.com/items?itemName=Tyriar.windows-terminal
MIT License
33 stars 8 forks source link

Make wslpath to string #29

Closed moxwel closed 3 years ago

moxwel commented 3 years ago

This PR fixes #28


https://github.com/Tyriar/vscode-windows-terminal/blob/d9f2f0c225bd7e986e3bc3a89e8ed9cd3e31fb72/src/wsl.ts#L4

I think the problem was that when there's a folder with spaces, the argument of the wslpath command gets "separated" and therefore, gets an error because there's "more" arguments.

Putting simple quotation marks makes the entire path ${p} literal, and therefore, if the path contain a folder with spaces in it, it don't get "separated" from the argument.

Works for me at least.

Tyriar commented 3 years ago

Released as 0.6.1, thanks!