Add positional arguments

[thorhj]

This is for issue #26 with the following shortcomings:

Tests are missing Will implement if the solution is approved.

Closes #26

[Tyrrrz]

Thanks! I will take a look.

[thorhj]

@Tyrrrz I have added a lot of commits to fix the issues you mentioned. There are still missing tests, but I don't think I can get to it the following week. You are welcome to implement tests if you wish, otherwise it will take some time :)

[Tyrrrz]

Sounds good and don't worry. I'm currently overloaded with issues myself (both real life and other projects) so I can't devote my full focus to CliFx yet :)

[thorhj]

Just so I'll remember, here is the stuff I need to write tests on:

Command resolution

• [x] Find most specific subcommand given name overlap

Help text

• [x] Usage line
• [x] Argument list

Argument validation

• [x] Multiple collection arguments must fail
• [x] Argument after collection argument must fail
• [x] Required arguments must appear before optional arguments
• [x] Argument order must be unique
• [x] No arguments with the same name

Input validation (command initialization)

• [x] Required arguments must be supplied
• [x] Arguments are mapped to correct properties based on order
• [x] Fail on extranous arguments (that does not match command nor positional argument)

NOTE: Consider moving validation to separate class to allow easy unit testing without creating numerous test commands.

[Tyrrrz]

Added some conflicts for you to make it more fun.

[thorhj]

@Tyrrrz I am picking this up again. Hope to have it done in a few days.

[thorhj]

@Tyrrrz Happy new years! I think all the work in this PR is done now -- what better way to start the new year than to code review? ;)

[Tyrrrz]

@thorhj Sounds like the best New Years gift to me :) I'll look at it soon. Happy holidays to you too!

[Tyrrrz]

@thorhj how is it going? :) Any chance you will have time to fix the few issues so I can merge it next week?

[thorhj]

@Tyrrrz It should be fixed now!

[Tyrrrz]

Thanks! 🎉