Closed domn1995 closed 4 years ago
Maybe we can open up an issue to remove those null!s and refactor accordingly just as general quality control.
I completely agree. Built-in options are a bit of hack right now because they're separate from the actual command. I'm still not sure how to handle it better.
@Tyrrrz, ready for round two :)
@Tyrrrz, ready for round three 🤞
Thanks! 🎉
Closes #18.
Notable Changes
HelpTextWriter
that retrieves possible enum values and appends them to the option description.Additional Comment
I'd also like to bring attention to the following null check: https://github.com/domn1995/CliFx/blob/7ff83c42066865cb4cf0354ed93694114128810a/CliFx/Domain/HelpTextWriter.cs#L264-L266
This was required even though nullable reference types reported that
Property
was non-nullable. That is due to the damn it operators here:https://github.com/Tyrrrz/CliFx/blob/cbb72b16ae2ba095abcd593cbddf6e8961ba10b8/CliFx/Domain/CommandOptionSchema.cs#L102-L106
Maybe we can open up an issue to remove those
null!
s and refactor accordingly just as general quality control.