Cannot pass negative doubles

[brianharwell]

I have a simple command...

[Command("calculate")]
    public class Calculate : ICommand
    {
        [CommandParameter(0, Name = "Latitude")]
        public double Latitude { get; set; }

        [CommandParameter(1, Name = "Longitude")]
        public double Longitude { get; set; }

        public ValueTask ExecuteAsync(IConsole console)
        {
            System.Console.WriteLine($"Latitude: {Latitude}");
            System.Console.WriteLine($"Longitude: {Longitude}");

            return default;
        }
    }

If I pass positive values it works...

.\Console.exe calculate 1 3
Latitude: 1
Longitude: 3

.\Console.exe calculate 1.6675 3.7655676
Latitude: 1.6675
Longitude: 3.7655676

If I pass negative numbers it fails...

.\Console.exe calculate -1.6675 -3.7655676
Missing value for parameter <Latitude>.

[brianharwell]

Even attempting to pass as strings fails...

.\Console.exe calculate "-1.6675" "-3.7655676"
Missing value for parameter <Latitude>.

[adambajguz]

hi, this is sth I have fixed in Typin. @Tyrrrz feel free to copy my idea.

PS. develop branch has a 3.0 developer preview version that has a much cleaner code than on master.

[brianharwell]

Sweet thanks!

[Tyrrrz]

Np. I'll try to release a new version next week

[brianharwell]

@Tyrrrz Would you please cut a release with this fix?

[Tyrrrz]

@brianharwell v1.6 should already have it

[brianharwell]

@Tyrrrz i thought it might so I updated and the parsing still fails

[Tyrrrz]

@brianharwell can you share a command that fails? maybe i missed some edge case

[brianharwell]

@Tyrrrz It's good. The mistake was on my end. Thanks!

[Tyrrrz]

@brianharwell glad to hear!